Skip to content
Succès

Changes

Summary

  1. Bug #14471 (details)
  2. Bug #14478 (details)
  3. Bug #14503 (details)
  4. bug #14334: add parameter action on method call addArrrayCellCheckbox (details)
Commit 07b3b89c2cf0ea1f587557356dc8de8092944206 by Miguel Moquillon
Bug #14471

A publication is a peculiar contribution in Silverpeas as it can be
located in several locations in the same or in different component
instances. In this case, we have the original publication along with its
all aliases. This capability is used in the Kmelia application. As
consequence, the publication is only referred uniquely by its local
identifier (its local identifier is its global one), whereas the others
types of contributions are identified uniquely by their global
identifier that is made up of their local identifier and of the
identifier of the application instance they belong to.

Despite this peculiarity, the indexation, the search and the
access rights computation treat the publications only by their local
identifier, and this can cause troubles when the aliases of a
publication (with the original one) are implied. For example, if an
alias was removed, then the index in which the alias is referred is
simply deleted, despite the fact there is others aliases or, worse,
there is the original publication referred by the index.

In the fix, we ensure now that all the treatments are done on both the
local identifier of the publication and the identifier of the
application instance it belongs to. And, in the management of the
indexes of the publications, they are deleted only if there is no
more publications (original one/aliases) referred by them.
And, in the access rights computation, in the case of a search,
we look for the access rights of nodes with specific rights in which
is linked the in-checking alias.
The file was modifiedcore-library/src/main/java/org/silverpeas/core/contribution/publication/dao/PublicationDAO.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/contribution/publication/model/PublicationDetail.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/security/authorization/PublicationAccessController.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/contribution/publication/model/PublicationIdentifier.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/contribution/publication/service/DefaultPublicationService.java (diff)
The file was modifiedcore-api/src/main/java/org/silverpeas/core/ResourceReference.java (diff)
The file was modifiedcore-library/src/integration-test/java/org/silverpeas/core/contribution/publication/service/PublicationDAOIT.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/contribution/publication/model/PublicationPK.java (diff)
The file was modifiedcore-library/src/test/java/org/silverpeas/core/security/authorization/PublicationDetail4Test.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/index/search/SimpleSearchEngine.java (diff)
Commit 2eea924bd09e06886490f39a71f9a5381e02100c by Miguel Moquillon
Bug #14478

In several very peculiar locations in the code, both in JS and in Java,
the filename, description or title of an attachment (or of a publication),
aren't correctly escaped for HTML rendering. Fix those omissions.
The file was modifiedcore-war/src/main/webapp/util/javaScript/silverpeas.js (diff)
The file was modifiedcore-web/src/main/java/org/silverpeas/core/webapi/attachment/SimpleDocumentResourceCreator.java (diff)
The file was modifiedcore-web/src/main/java/org/silverpeas/core/webapi/attachment/SimpleDocumentResource.java (diff)
The file was modifiedcore-war/src/main/webapp/attachment/jsp/displayAttachedFiles.jsp (diff)
The file was modifiedcore-war/src/main/webapp/WEB-INF/tags/silverpeas/util/commonDragAndDrop.tag (diff)
The file was modifiedcore-war/src/main/webapp/util/javaScript/silverpeas-fileUpload.js (diff)
The file was modifiedcore-war/src/main/java/org/silverpeas/web/notificationuser/servlets/UserNotificationRequestRouter.java (diff)
The file was modifiedcore-war/src/main/webapp/portlets/jsp/lastPublications/portlet.jsp (diff)
The file was modifiedcore-war/src/main/webapp/util/javaScript/silverpeas-ddUpload.js (diff)
The file was modifiedcore-web/src/main/java/org/silverpeas/core/web/attachment/tag/SimpleDocumentContextualMenu.java (diff)
The file was modifiedcore-war/src/main/webapp/portlets/jsp/myLastPubliRead/portlet.jsp (diff)
The file was modifiedcore-war/src/main/webapp/socialNetwork/jsp/js/newsfeed.js (diff)
The file was modifiedcore-war/src/main/webapp/WEB-INF/tags/silverpeas/util/attachmentDragAndDrop.tag (diff)
Commit 41105579ca8dc7d5d00c907580c9141a76687a9e by Miguel Moquillon
Bug #14503

The move of a node was done by deleting and then recreating in database
the node with its new location, and this without updating its
translations to refer the correct new node.

Replace the deletion and then the creation of the moved node by a simple
suitable update: in fact, a move method already existed in the NodeDAO
but it wasn't anymore used. This method update accordingly a node
details in the database for a node move. The translations of the node
are then not lost.

Refine the update of a node in DefaultNodeService by avoiding to
retrieve again from the database the current node before update; Get it
at first, then use it all along the update process.
The file was modifiedcore-library/src/main/java/org/silverpeas/core/node/model/NodeDetail.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/node/dao/NodeDAO.java (diff)
The file was modifiedcore-library/src/main/java/org/silverpeas/core/node/service/DefaultNodeService.java (diff)
Commit 483a1022154838003e97a6b30e217e7446acf4ee by Miguel Moquillon
bug #14334: add parameter action on method call addArrrayCellCheckbox
The file was modifiedcore-war/src/main/webapp/workflowDesigner/jsp/editState.jsp (diff)
The file was modifiedcore-war/src/main/webapp/workflowDesigner/jsp/editColumns.jsp (diff)
The file was modifiedcore-war/src/main/webapp/workflowDesigner/jsp/editQualifiedUsers.jsp (diff)
The file was modifiedcore-war/src/main/webapp/workflowDesigner/jsp/editConsequence.jsp (diff)
The file was modifiedcore-war/src/main/webapp/workflowDesigner/jsp/editInput.jsp (diff)
The file was modifiedcore-war/src/main/webapp/workflowDesigner/jsp/editItem.jsp (diff)

Summary

  1. Bug #14471 (details)
  2. Bug #14478 (details)
  3. Bug #14503 (details)
  4. bug #14483: Wrong label (details)
Commit a3fe2e4ee431bc4d1def0c7717055f704ffbacd2 by Miguel Moquillon
Bug #14471

A publication is a pueculiar contribution in Silverpeas as iti can be
located in several locations in the same or in different component
instances. In this case, we have the original publication along with
its all aliases. This capability is used in the Kmelia application.
As consequence, the publication is only referred uniquely by its
local identifier (its local identifier is its global one), whereas
the others types of contributions are identified uniquely by their
global identifier that is made up of their local identifier and of
the identifier of the application instance they belong to.

Despite this peculiarity, the authorization mechanism in Kmelia takes
the publication by their local identifier and, in a such context, any
access right validation can be incorrect on publication aliases
located in a topic for which specific access rights have been set.

Now, the publications, whatever they are (original one or aliases) are
taken in charge by both their local identifier and the identifier of the
component instance they belong to.
The file was modifiedkmelia/kmelia-library/src/main/java/org/silverpeas/components/kmelia/KmeliaComponentAuthorization.java (diff)
Commit 2e21520ab032b09a4eee29ca8e36a330296766bf by Miguel Moquillon
Bug #14478

In several peculiar locations, the filename, title or description of an
attachment aren't correctly escaped for HTML rendering. Fix those
issues.

Refactor the rendering process in AjaxPublicationListServlet in order
first to separate in a way some responsibilities, and to fix the issues
sent back by Sonar.
The file was modifiedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/AjaxPublicationsListServlet.java (diff)
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/PublicationsRenderer.java
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/RenderingContext.java
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/publicationsList.jsp (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/defermentMotive.jsp (diff)
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/Renderer.java
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/styleSheets/kmelia.css (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/kmax_axisReport.jsp (diff)
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/PublicationFragmentSettings.java
The file was removedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/PublicationFragmentSettings.java
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/ForbiddenAccessRenderer.java
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/importOneFile.jsp (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/publication.jsp (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/publicationManager.jsp (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/orderPublications.jsp (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/topicReport.jsp (diff)
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/checkKmelia.jsp (diff)
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/LastPublicationsRenderer.java
The file was addedkmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/NothingRenderer.java
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/importMultiFiles.jsp (diff)
Commit a1b965e46ecc0b2dd778b8695c5cb7cc41a47151 by Miguel Moquillon
Bug #14503

By testing the fix of the bug, I discovered a nasty hidden bug in js
when adding a new translation for a given topic: when the properties of a
topic is rendered, an HTML select element is updated with the
translations of the node's properties. If we ask to see the properties
of a topic for which its name and description were translated for all of
the supported languages, the HTML select element is correctly updated.
But, if after we ask to see the properties of another topic for which a
translation is missed, then the HTML select element isn't correctly
updated for the missed translation: instead of having for the missing
translation an identifier of -1, it kept the id of the translation of
the previous selected topic for the same language.

Fix this bug.
The file was modifiedkmelia/kmelia-war/src/main/webapp/kmelia/jsp/javaScript/navigation.js (diff)
The file was modifiedkmelia/kmelia-configuration/src/main/config/xmlcomponents/toolbox.xml (diff)
The file was modifiedkmelia/kmelia-configuration/src/main/config/xmlcomponents/kmelia.xml (diff)

Summary

  1. Bug #14478 (details)
Commit 16371448b9ca33b5ba72efd140bf2eb3c72daa8a by Miguel Moquillon
Bug #14478

Escape for HTML rendering the title and the description of a publication
in the block of the last authored publications.
The file was modifiedaurora/aurora-war/src/main/webapp/WEB-INF/tags/silverpeas/look/displayPublications.tag (diff)